-
Notifications
You must be signed in to change notification settings - Fork 178
Move core directories and files to databricks directory #937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
parthban-db
merged 15 commits into
dev/sdk-mod
from
parthban-db/move-core-to-databricks
Mar 31, 2025
Merged
Move core directories and files to databricks directory #937
parthban-db
merged 15 commits into
dev/sdk-mod
from
parthban-db/move-core-to-databricks
Mar 31, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaudhartert-db
approved these changes
Mar 28, 2025
hectorcast-db
approved these changes
Mar 31, 2025
parthban-db
added a commit
that referenced
this pull request
Mar 31, 2025
This reverts commit 6cd1b70.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR moves all the "core" directories and files into the "databricks" directory, which is meant to become the core library.
This PR also comments out some tests(specifically tests in tests/integration/test_auth.py) that upload the current copy of the Python SDK to the workspace and use that copy to run some notebook code. The reason for commenting out these tests is that Databricks Connect depends on the Python SDK in the workspace. However, Due to the directory changes, the dependency path in Databricks Connect no longer matches this change. As SDK Mod represents a complete architectural change of the SDK Beta, we cannot simply use it in the DB connect, and we need to update it accordingly.
How is this tested?
Existing Tests.
NO_CHANGELOG=true